Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:progress): fix circle gradient not sorted #4178

Merged
merged 6 commits into from
Sep 20, 2019
Merged

fix(module:progress): fix circle gradient not sorted #4178

merged 6 commits into from
Sep 20, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Sep 18, 2019 •
edited
Loading

close #4176

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4176

What is the new behavior?

Circle gradient stops would now be sorted.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@auto-assign auto-assign bot requested a review from cipchk September 18, 2019 08:39
@netlify
Copy link

netlify bot commented Sep 18, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit 0ac0da5

https://deploy-preview-4178--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Sep 18, 2019 •
edited
Loading

Codecov Report

Merging #4178 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4178      +/-   ##
==========================================
+ Coverage   92.27%   92.29%   +0.02%     
==========================================
  Files         517      517              
  Lines       10962    10966       +4     
  Branches     1985     1985              
==========================================
+ Hits        10115    10121       +6     
+ Misses        422      421       -1     
+ Partials      425      424       -1
Impacted Files Coverage Δ
components/progress/nz-progress.component.ts 95.87% <100%> (+0.13%) ⬆️
components/progress/nz-progress-utils.ts 90% <100%> (+11.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9900ed...0ac0da5. Read the comment docs.

@wzhudev wzhudev merged commit 7d37b1c into NG-ZORRO:master Sep 20, 2019
@wzhudev wzhudev deleted the progress-gradient branch September 20, 2019 07:51
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@Ricbet
fix(module:progress): fix circle gradient not sorted (NG-ZORRO#4178)
bc2c912 
* fix(module:progress): fix circle gradient not sorted
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
fix(module:progress): fix circle gradient not sorted (NG-ZORRO#4178)
c72a5b2 
* fix(module:progress): fix circle gradient not sorted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenqi73 wenqi73 wenqi73 approved these changes

@cipchk cipchk Awaiting requested review from cipchk

Assignees

@hsuanxyz hsuanxyz

Labels
PR: merged PR: target-patch PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fail to show over two colors with linear-gradient circle progress
3 participants
@wzhudev @wenqi73 @hsuanxyz